This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA][1/5] New port: Cell BE SPU (dwarf2loc.c fix)


"Ulrich Weigand" <uweigand@de.ibm.com> writes:
>> Would it be a good idea to introduce a new function, a companion to
>> value_from_register, that wraps up the composition of
>> value_from_register and value_as_address?
>
> You mean something like the patch below?  Tested on spu, s390-ibm-linux
> and s390x-ibm-linux.

Yes, that's great.  Please commit.

It seems a shame to be creating a value and then throwing it away, but
the composition of those two functions has the semantics we want, so I
don't see a good alternative without some more restructuring.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]