This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Committed: fix build of sim/d10v (invert common=no default)


If there's ever a simulator that doesn't need the subdir
"common", they'll now have to add common=no.  Instead of all
others needing common=yes and then someone will eventually miss
that, causing confusion (QED) that manifests as:

gcc -c /x/src/sim/d10v/../common/callback.c -DHAVE_CONFIG_H     -DPROFILE=1 -DWITH_PROFILE=-1          -DDEFAULT_INLINE=0       -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized    -DNEED_UI_LOOP_HOOK -DSIM_HAVE_ENVIRONMENT   -I. -I/x/src/sim/d10v -I../common -I/x/src/sim/d10v/../common -I../../include -I/x/src/sim/d10v/../../include -I../../bfd -I/x/src/sim/d10v/../../bfd -I../../opcodes -I/x/src/sim/d10v/../../opcodes  -g -O2
/x/src/sim/common/callback.c:26:21: cconfig.h: No such file or directory
/x/src/sim/common/callback.c: In function `os_close':
/x/src/sim/common/callback.c:177: warning: implicit declaration of function `free'
(many similar)

Committed.

src/sim:
	* configure.ac (common): Make the default "yes" for all targets
	with sim subdirs.
	* configure: Regenerate.

Index: configure.ac
===================================================================
RCS file: /cvs/src/src/sim/configure.ac,v
retrieving revision 1.10
diff -p -u -r1.10 configure.ac
--- configure.ac	8 Aug 2006 18:57:25 -0000	1.10
+++ configure.ac	21 Dec 2006 00:11:22 -0000
@@ -44,18 +44,16 @@ esac])
 
 if test "${enable_sim}" != no; then
    testsuite=no
-   common=no
+   common=yes
    igen=no
    case "${target}" in
        arm*-*-* | thumb*-*-* | strongarm*-*-* | xscale-*-*)
            AC_CONFIG_SUBDIRS(arm)
 	   testsuite=yes
-	   common=yes
 	   ;;
        cris-*-* | crisv32-*-*)
 	   AC_CONFIG_SUBDIRS(cris)
 	   testsuite=yes
-	   common=yes
 	   ;;
        d10v-*-*)
            AC_CONFIG_SUBDIRS(d10v)
@@ -63,72 +61,62 @@ if test "${enable_sim}" != no; then
        frv-*-*)
            AC_CONFIG_SUBDIRS(frv)
 	   testsuite=yes
-	   common=yes
 	   ;;
        h8300*-*-*)
            AC_CONFIG_SUBDIRS(h8300)
 	   testsuite=yes
-	   common=yes
 	   ;;
        iq2000-*-*)
            AC_CONFIG_SUBDIRS(iq2000)
 	   testsuite=yes
-	   common=yes
 	   ;;
        m32c-*-*)
            AC_CONFIG_SUBDIRS(m32c)
-           common=yes
            ;;
        m32r-*-*)
            AC_CONFIG_SUBDIRS(m32r)
 	   testsuite=yes
-	   common=yes
 	   ;;
        m68hc11-*-*|m6811-*-*)
            AC_CONFIG_SUBDIRS(m68hc11)
 	   testsuite=yes
-	   common=yes
 	   ;;
        mcore-*-*)
            AC_CONFIG_SUBDIRS(mcore)
 	   testsuite=yes
-	   common=yes
 	   ;;
        mips*-*-*)
            AC_CONFIG_SUBDIRS(mips)
 	   testsuite=yes
-	   common=yes
 	   igen=yes
 	   ;;
        mn10300*-*-*)
            AC_CONFIG_SUBDIRS(mn10300)
-	   common=yes
 	   igen=yes
 	   ;;
        sh64-*-*)
            AC_CONFIG_SUBDIRS(sh64)
 	   testsuite=yes
-	   common=yes
 	   ;;
        sh-*-*)
            AC_CONFIG_SUBDIRS(sh)
 	   testsuite=yes
-	   common=yes
 	   ;;
        sparc-*-rtems*|sparc-*-elf*)
 	   AC_CONFIG_SUBDIRS(erc32)
 	   testsuite=yes
-	   common=yes
 	   ;;
        powerpc*-*-* )
            AC_CONFIG_SUBDIRS(ppc)
-	   common=yes
 	   ;;
        v850*-*-* )
            AC_CONFIG_SUBDIRS(v850)
-	   common=yes
 	   igen=yes
 	   ;;
+       *)
+	   # No simulator subdir, so the subdir "common" isn't needed.
+	   common=no
+	   ;;
    esac
    if test "$testsuite" = yes; then
       AC_CONFIG_SUBDIRS(testsuite)

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]