This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/sparc64] internal-error printing return value (Ada array) - take 2


> Date: Sun, 24 Dec 2006 13:36:15 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> 
> Hello Mark,
> 
> Following our disccussion that started at:
> 
>     http://www.sourceware.org/ml/gdb-patches/2006-11/msg00076.html
> 
> I finally found the time to make the change you suggested, and then
> test it again.
> 
> 2006-12-24  Joel Brobecker  <brobecker@adacore.com>
> 
>         * sparc64-tdep.c (sparc64_extract_return_value): Add handling
>         for array types.
>         (sparc64_store_return_value): Likewise.
> 
> Tested on sparc64-sun-solaris2.8, no regression. OK to commit?

Could you change the comment from

/* Small arrays are returned the same way as small records.  */

into

/* Small arrays are returned the same way as small structures.  */

?

With that change this is ok.

However, did you check how small arrays of floating-point numbers are returned?
I suspect there might be an issue with those.

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]