Re: [RFC/RFA] Add support for catch Ada exceptions

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Sat, 30 Dec 2006 07:21:11 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> 
> Here is a patch that adds support for "catch"-ing Ada exceptions.

Thanks!

>     (gdb) catch exception
>     Catchpoint 1 on all Ada exceptions at 0x804b7c0
>     (gdb) info break
>     Num Type           Disp Enb Address    What
>     1   catch exception keep y   0x0804b7c0 on all Ada exceptions

I don't like this ``on'' business.  How about removing it?

    (gdb) catch exception
    Catchpoint 1: all Ada exceptions at 0x804b7c0
    (gdb) info break
    Num Type           Disp Enb Address    What
    1   catch exception keep y   0x0804b7c0 all Ada exceptions

>     (gdb) catch exception program_error
>     Catchpoint 1 on `program_error' Ada exception at 0x804b7c0
>     (gdb) catch assert    
>     Catchpoint 2 on failed Ada assertions at 0x804c437
>     (gdb) catch exception unhandled
>     Catchpoint 3 on unhandled Ada exceptions at 0x804ad2d

Again, removing the ``on'' part makes it sound better, IMO:

    (gdb) catch exception program_error
    Catchpoint 1: `program_error' Ada exception at 0x804b7c0
    (gdb) catch assert    
    Catchpoint 2: failed Ada assertions at 0x804c437
    (gdb) catch exception unhandled
    Catchpoint 3: unhandled Ada exceptions at 0x804ad2d

Btw, do we need to display the address?  The fact that you actually
implement this as breakpoints is an implementation detail; the user
doesn't need to know, I think.

> I will also write some documentation, but I want to make sure that
> at least the user-interface is agreed on before I start this work.

You have my blessing for the UI, with the exception of the above minor
comments.  I'm eagerly awaiting to see the docs ;-).