This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Return value cleanup in rs6000-tdep.c


> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
> 	* rs6000-tdep.c (rs6000_use_struct_convention)
> 	(rs6000_extract_return_value, rs6000_store_return_value)
> 	(rs6000_extract_struct_value_address): Remove.
> 	(rs6000_return_value): New function.
> 	(rs6000_gdbarch_init): Don't set deprecated_extract_return_value,
> 	store_return_value, deprecated_extract_struct_value_address and
> 	deprecated_use_struct_convention.  Use rs6000_return_value
> 	instead.

The planets must be in the right alignment. The testsuite took way less
time to complete than the actual build. Here are the only differences
(before and after):

* gdb.base:
+------------+------------+----------------------------------------------------+
|       FAIL | PASS       | call-sc.exp: value foo returned; return call-sc-tc |
|       FAIL | PASS       | call-sc.exp: value foo returned; return call-sc-ts |
|       FAIL | PASS       | call-sc.exp: value foo returned; return call-sc-tf |
|       FAIL | PASS       | return2.exp: char value returned successfully      |
|       FAIL | PASS       | return2.exp: short value returned successfully     |
|       FAIL | PASS       | return2.exp: validate result value not equal t ... |
|            |            | ... o program return value                         |
|       FAIL | PASS       | return2.exp: float value returned successfully     |
+------------+------------+----------------------------------------------------+

Thanks a lot for this patch, Mark.
-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]