This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: MI - Detecting change of string contents with variable objects
- From: Daniel Jacobowitz <drow at false dot org>
- To: Nick Roberts <nickrob at snap dot net dot nz>
- Cc: Vladimir Prus <ghost at cs dot msu dot su>, gdb-patches at sources dot redhat dot com
- Date: Wed, 3 Jan 2007 17:46:05 -0500
- Subject: Re: RFC: MI - Detecting change of string contents with variable objects
- References: <17797.65268.689590.797944@kahikatea.snap.net.nz> <E1GwCV8-0008SD-TG@zigzag.lvk.cs.msu.su> <17798.19683.251190.740216@kahikatea.snap.net.nz> <200612181136.02429.ghost@cs.msu.su> <20061218133827.GA24800@nevyn.them.org> <17799.3497.476593.138858@kahikatea.snap.net.nz>
On Tue, Dec 19, 2006 at 10:52:41AM +1300, Nick Roberts wrote:
> That's a vary good idea. Here's a revised patch that isn't language dependent.
> In addition to detecting string contents changes it detects when the output
> format has changed with -var-set-format. I don't see this as a bad thing
> and it means that my patch earlier in the year for including the value
> in the output of -var-set-format probably isn't needed.
Sounds good. I generally agree with Vladimir about reusing
c_value_of_variable, however.
I believe it is as simple as:
- Passing a struct value *.
- Always returning NULL if there is no value, instead of doing
the struct and array special cases first.
- Using value_type to get the type code and the number of children.
- Probably calling value_fetch_lazy first when passing it the new
value, to avoid the assertions.
Let me know if you want me to try that myself.
--
Daniel Jacobowitz
CodeSourcery