This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] testsuite fixes for stubs
- From: Daniel Jacobowitz <drow at false dot org>
- To: Pedro Alves <pedro_alves at portugalmail dot pt>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 4 Jan 2007 15:43:02 -0500
- Subject: Re: [PATCH] testsuite fixes for stubs
- References: <45805E69.2080403@portugalmail.pt>
On Wed, Dec 13, 2006 at 08:11:21PM +0000, Pedro Alves wrote:
> Hi all,
>
> The attached patch removes 109 FAILS while testing the yet unsubmitted
> arm-wince gdbserver port.
> These FAILS should be happening on testsuite runs ran against most
> gdbserver/stub.
Nope - but it does sometimes sometimes. This will only trigger if you
have debugging info for the file containing _start.
> 2006-12-13 Pedro Alves <pedro_alves@portugalmail.pt>
>
> * gdb.base/charset.exp: Add explicit filename to break.
> * gdb.base/dbx.exp: Add explicit filename to breaks.
I checked in something almost the same. You don't need "\." on the
left side, and in fact it does nothing (TCL turns "\." into "."). And
charset.exp has a handy ${srcfile}.
--
Daniel Jacobowitz
CodeSourcery
2007-01-04 Pedro Alves <pedro_alves@portugalmail.pt>
* gdb.base/charset.exp: Add explicit filename to break.
* gdb.base/dbx.exp: Add explicit filename to breaks.
Index: gdb.base/charset.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/charset.exp,v
retrieving revision 1.6
diff -u -p -r1.6 charset.exp
--- gdb.base/charset.exp 13 May 2005 17:36:43 -0000 1.6
+++ gdb.base/charset.exp 4 Jan 2007 20:41:32 -0000
@@ -388,7 +388,7 @@ foreach host_charset [all_charset_names]
# some strings in various target character sets. We need to run the
# test program to the point at which the strings have been
# initialized.
-gdb_test "break [gdb_get_line_number "all strings initialized"]" \
+gdb_test "break ${srcfile}:[gdb_get_line_number "all strings initialized"]" \
".*Breakpoint.* at .*" \
"set breakpoint after all strings have been initialized"
gdb_run_cmd
Index: gdb.base/dbx.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/dbx.exp,v
retrieving revision 1.5
diff -u -p -r1.5 dbx.exp
--- gdb.base/dbx.exp 10 Aug 2006 05:27:20 -0000 1.5
+++ gdb.base/dbx.exp 4 Jan 2007 20:41:32 -0000
@@ -266,8 +266,8 @@ proc gdb_file_cmd {arg} {
proc test_breakpoints { } {
gdb_test "stop in main" "Breakpoint.*at.*: file.*average\.c, line 38\."
gdb_test "status" "Num.*Type.*Disp.*Enb.*Address.*What\r\n1\[ \r\]+breakpoint\[ \r\]+keep y.*in main at.*average\.c:38.*"
- gdb_test "stop at 43" "Breakpoint.*at.*: file.*average\.c, line 43.*"
- gdb_test "stop in 43" "Usage: stop in <function . address>"
+ gdb_test "stop at average.c:43" "Breakpoint.*at.*: file.*average\.c, line 43.*"
+ gdb_test "stop in average.c:43" "Usage: stop in <function . address>"
gdb_test "stop at main" "Usage: stop at <line>"
}