This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC][1/2] Rework value_from_register


"Ulrich Weigand" <uweigand@de.ibm.com> writes:
> ChangeLog:
>
> 	* frame.c (get_frame_register_bytes): New function.
> 	(put_frame_register_bytes): Likewise.
> 	* frame.h (get_frame_register_bytes): Declare.
> 	(put_frame_register_bytes): Likewise.
> 	* findvar.c (value_from_register): Always construct lval_register
> 	values.  Use get_frame_register_bytes.
> 	* valops.c (value_assign): Use get_frame_register_bytes and
> 	put_frame_register_bytes.

This looks great.  Tested without regressions on IA-32 Fedora Core 6.

One suggestion: common practice seems to put detailed explanations of
functions' interfaces in frame.h, and place no comment above the
definition in frame.c.  I think it's better to have one full
explanation, instead of two that can get out of sync.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]