This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PING: [RFA/i386] 2 more patterns in i386_analyze_stack_align

From: Joel Brobecker <brobecker at adacore dot com>
To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
Cc: gdb-patches at sourceware dot org
Date: Fri, 5 Jan 2007 18:37:28 +0400
Subject: Re: PING: [RFA/i386] 2 more patterns in i386_analyze_stack_align
References: <20061220104945.GB27642@adacore.com> <20061231060844.GP3640@adacore.com> <200612311215.kBVCF75Z010607@brahms.sibelius.xs4all.nl> <20070105064916.GS17211@adacore.com> <200701051104.l05B4xl1024647@brahms.sibelius.xs4all.nl>

> Ah wait, that's true even for "absolute" code.  I had a quick look at
> the GCC code and it seems to always treat %ebx as callee-saved.  So
> I'm happy with leaving it out, but you could add a comment saying so
> to prevent us from having this same discussion in about two months
> ;-).

Sure! How does the attached patch look? Does it contain enough info?

2007-01-05  Joel Brobecker  <brobecker@adacore.com>

        * i386-tdep.c (i386_analyze_stack_align): Add comment.

-- 
Joel

Attachment: comment.diff
Description: Text document

Follow-Ups:
- Re: PING: [RFA/i386] 2 more patterns in i386_analyze_stack_align
  - From: Mark Kettenis

References:
- Re: PING: [RFA/i386] 2 more patterns in i386_analyze_stack_align
  - From: Joel Brobecker
- Re: PING: [RFA/i386] 2 more patterns in i386_analyze_stack_align
  - From: Mark Kettenis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]