Re: RFC: MI - Detecting change of string contents with variable objects

[Nick Roberts <nickrob at snap dot net dot nz>]

 > > I've also used:
 > >  
 > >   strcmp (var->print_value, print_value) != 0
 > > 
 > > since that method seems to be the norm in varobj.c, and GDB generally.
 > 
 > Please, when you commit a patch, post it.  That means the final
 > version, including a ChangeLog entry.

I did this initially, but on re-reading CONTRIBUTE and MAINTAINERS I couldn't
see why (perhaps Andrew instructed me).  I stopped because I thought the posts
were very similar to the previous one and I felt I was creating too much noise
on gdb-patches.  Also the mailing list gdb-cvs, which global maintainers are
presumably subscribed to, provides this very information.

 >                                        This holds for obvious patches,
 > patches that you commit with minor changes, whatever.

I usually still do this.

 > > I've committed this change, which you might not like, because I think
 > > Vladimir is agreeable to it.  Of course, I'll make changes, including
 > > reversion, if there are problems.
 > 
 > I think I was pretty clear that approval was conditional on hearing
 > from Vlad.  You went ahead and committed it anyway.

You said "This looks fine to me if it's fine with Vlad."  He was part of the
thread and I addressed his last reservation.  It's not clear to me, at least,
that he needs to explicitly express his approval.

 > You committed a patch without running the testsuite beforehand.  In
 > general you shouldn't even post patches without doing that.  We
 > all make this mistake periodically, but please try harder.

Yes, this is my mistake - sorry.  I'll have to improve the way I handle
multiple patches.

 > You committed a patch to move the select_frame call without, as far as
 > I can see from my weekend mail, even posting it.

My mistake again - sorry.

 > Nick, I'm disappointed in your behavior.  I'm past caring whether
 > you are frustrated with the pace of progress; especially after I spent
 > most of an entire work day that I couldn't really afford to catch up
 > on patch review.  We have rules that contributors are expected to
 > follow.  In the future, please follow them.

All I can say is that I'm probably trying harder than you think.

-- 
Nick                                           http://www.inet.net.nz/~nickrob