This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Fix 'selected frame' varobjs
- From: Daniel Jacobowitz <drow at false dot org>
- To: Vladimir Prus <ghost at cs dot msu dot su>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 9 Jan 2007 16:45:14 -0500
- Subject: Re: Fix 'selected frame' varobjs
- References: <200612310301.42649.ghost@cs.msu.su> <20061231214221.GB26604@nevyn.them.org> <E1H4OPc-0008Mo-NF@zigzag.lvk.cs.msu.su>
On Wed, Jan 10, 2007 at 12:20:55AM +0300, Vladimir Prus wrote:
> What about the attached?
>
> - Volodya
>
> 2006-12-31 Daniel Jacobowitz <dan@codesourcery.com>
> Vladimir Prus <vladimir@codesourcery.com>
>
> Fix 'selected frame' varobjs.
> * varobj.c (struct varobj): Remove the error field.
> (varobj_set_value): Don't check var->error.
> (install_new_value): Don't set var->error.
> (varobj_update): Always pass the new value
> of the root via install_new_value.
> (create_child): Don't set error field.
> (new_variable): Likewise.
> (c_value_of_root): Always reevaluate the value
> of selected frame varobjs in the selected frame.
> Don't call reinit_frame_cache.
Looks good to me - this is OK.
--
Daniel Jacobowitz
CodeSourcery