This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: Initialize tmp_obstack
- From: Daniel Jacobowitz <drow at false dot org>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: gdb-patches at sourceware dot org, hongjiu dot lu at intel dot com
- Date: Sun, 21 Jan 2007 10:59:41 -0500
- Subject: Re: PATCH: Initialize tmp_obstack
- References: <20061205204003.GB25572@nevyn.them.org> <12601.163.1.150.229.1165354805.squirrel@webmail.xs4all.nl> <20061205214306.GA29801@nevyn.them.org> <20637.163.1.150.229.1165355320.squirrel@webmail.xs4all.nl> <20061205215639.GA30371@nevyn.them.org> <20061205235848.GA2551@nevyn.them.org> <20061207144018.GA12915@nevyn.them.org> <20061225040032.GA29719@nevyn.them.org> <20070116065937.GA15794@nevyn.them.org> <200701211307.l0LD7EO0000187@brahms.sibelius.xs4all.nl>
On Sun, Jan 21, 2007 at 02:07:14PM +0100, Mark Kettenis wrote:
> I had another look and come up with the attached. By always
> initializing tmp_obstack the code is less optimal, but at least I can
> convince myself the code is safe now. Unfortunately I can't test
> whether this fixes the GCC 4.1 warnings.
Thanks! I can test it - I'll let you know this afternoon.
p-valprint.c has the same problem, but the correct fix there is going
to be to delete some code. Pascal copied a lot from C/C++ but it
doesn't actually have static members to the best of my knowledge.
I see some discussion of them as planned for GNU Pascal, but no
implementations.
--
Daniel Jacobowitz
CodeSourcery