Re: [RFA] Allow use of breakpoint commands inside `if' or `while'

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Sat, 20 Jan 2007 15:33:52 -0500
> From: Daniel Jacobowitz <drow@false.org>
> Cc: gdb-patches@sources.redhat.com
> > 
> > Here it is.  It is admittedly inelegant; in particular, the
> > diagnostics for a GDB that fails the test is not very smart, and one
> > of the two tests isn't counted in the sum of failed tests, although it
> > does fail.  Hopefully, someone more fluent with Expect will be able to
> > improve on the test (I think Daniel offered help back when I first
> > reported this).
> 
> I did indeed.  How does this look?

Looks fine, thanks.  With an unpatched GDB it fails:

    Running ./gdb.base/commands.exp ...
    FAIL: gdb.base/commands.exp: commands - if_commands_test 1
    FAIL: gdb.base/commands.exp: silent - if_commands_test 1
    FAIL: gdb.base/commands.exp: set $tem = 3 - if_commands_test 1
    FAIL: gdb.base/commands.exp: continue - if_commands_test 1
    FAIL: gdb.base/commands.exp: first end - if_commands_test 1
    FAIL: gdb.base/commands.exp: second end - if_commands_test 1
    FAIL: gdb.base/commands.exp: commands - if_commands_test 2
    FAIL: gdb.base/commands.exp: silent - if_commands_test 2
    FAIL: gdb.base/commands.exp: set $tem = 3 - if_commands_test 2
    FAIL: gdb.base/commands.exp: continue - if_commands_test 2
    FAIL: gdb.base/commands.exp: first end - if_commands_test 2
    FAIL: gdb.base/commands.exp: second end - if_commands_test 2

		    === gdb Summary ===

    # of expected passes            95
    # of unexpected failures        12

    make[1]: *** [just-check] Error 1

While after patching it succeeds:

    Running ./gdb.base/commands.exp ...
    
                    === gdb Summary ===
    
    # of expected passes            107