This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Patch for QUIT macro support


 > > > We really should not put history in our comments.
 > > 
 > > Good point.  Here is a patch with updated comments.
 > > 
 > > It would be good if someone could independently review, test, and
 > > approve this, particularly anyone using an interface other than the
 > > normal command line one.
 > 
 > > 2007-01-22  Fred Fish  <fnf@specifix.com>
 > > 
 > > 	* event-top.c (handle_sigint): Set quit_flag.
 > > 	(async_request_quit): Don't set quit_flag.  Avoid calling quit()
 > > 	if quit_flag has already been reset.
 > 
 > Well, I independently reviewed it - I think this is correct.  I
 > can't readily test it with any other interface at the moment, but I
 > think you should commit this.  We'll have a while to catch any problems
 > if there's something we didn't think of.

But this is really Apple's change isn't it?  Even the comments (minus history)
are Apple's.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]