This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ob] fix mingw compilation


> Date: Thu, 8 Feb 2007 11:25:12 -0500
> From: Daniel Jacobowitz <drow@false.org>
> Cc: Vladimir Prus <vladimir@codesourcery.com>,
> 	gdb-patches@sources.redhat.com
> 
> > > -  HANDLE pipeline_out = (HANDLE) _get_osfhandle (scb->fd);
> > > +  HANDLE pipeline_out;
> > 
> > This one-line change is unnecessary; please put back the original
> > code, it's perfectly valid C, and shouldn't trigger any warnings or
> > errors from GCC.
> 
> It's valid either way, of course.

Sure, but I don't like unnecessary changes.

> In the interests of all getting along, I checked this in (to get the
> message out of my todo queue :-).

Thanks!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]