This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [ob] fix mingw compilation
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Daniel Jacobowitz <drow at false dot org>
- Cc: vladimir at codesourcery dot com, gdb-patches at sources dot redhat dot com
- Date: Fri, 09 Feb 2007 17:26:57 +0200
- Subject: Re: [ob] fix mingw compilation
- References: <200701301337.14436.vladimir@codesourcery.com> <uwt348dru.fsf@gnu.org> <20070208162512.GB11806@nevyn.them.org>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Thu, 8 Feb 2007 11:25:12 -0500
> From: Daniel Jacobowitz <drow@false.org>
> Cc: Vladimir Prus <vladimir@codesourcery.com>,
> gdb-patches@sources.redhat.com
>
> > > - HANDLE pipeline_out = (HANDLE) _get_osfhandle (scb->fd);
> > > + HANDLE pipeline_out;
> >
> > This one-line change is unnecessary; please put back the original
> > code, it's perfectly valid C, and shouldn't trigger any warnings or
> > errors from GCC.
>
> It's valid either way, of course.
Sure, but I don't like unnecessary changes.
> In the interests of all getting along, I checked this in (to get the
> message out of my todo queue :-).
Thanks!