This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] varobj.c
- From: Daniel Jacobowitz <drow at false dot org>
- To: Nick Roberts <nickrob at snap dot net dot nz>, Vladimir Prus <vladimir at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 27 Feb 2007 12:04:03 -0500
- Subject: Re: [PATCH] varobj.c
- References: <17875.38347.137214.962583@kahikatea.snap.net.nz>
On Thu, Feb 15, 2007 at 12:05:47PM +1300, Nick Roberts wrote:
>
> Following Denis' patch, this patch makes GDB throw a user error if a non
> root variable is used for -var-update. Currently GDB does:
>
> (gdb)
> -var-update var1.1
> ^done,changelist=[{name="var1.1",in_scope="false"}]
> (gdb)
>
> even though the expression that var1.1 represents may be inscope and have
> changed value.
Vladimir, didn't you have some in-progress patch that actually wanted
to update root varobjs? Anyway, if so, we can change it back later.
> 2007-02-15 Nick Roberts <nickrob@snap.net.nz>
>
> * varobj.c (varobj_update): Remove unused local. Use gdb_assert
> to check changelist is non-NULL. Call error if the frontend tries
> to update a non-root variable.
>
> * varobj.h (enum varobj_update_error): Delete WRONG_PARAM value.
OK.
--
Daniel Jacobowitz
CodeSourcery