This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: TUI + gdbserver broken?
- From: Daniel Jacobowitz <drow at false dot org>
- To: Pedro Alves <pedro_alves at portugalmail dot pt>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 18 Mar 2007 22:11:45 -0400
- Subject: Re: TUI + gdbserver broken?
- References: <45FDECB3.5000002@portugalmail.pt>
Thanks for all your detective work on this. I'm sorry I apparently
broke TUI so badly - I wish we had test coverage.
On Mon, Mar 19, 2007 at 01:51:47AM +0000, Pedro Alves wrote:
> The problem is that we now call deprecated_safe_get_selected_frame
> in tui_selected_frame_level_changed_hook... :
Before I look at your patch, could you check one more thing for me:
what's the backtrace look like when we get here?
> The attached patch fixes it by calling target_mark_running, and
> target_mark_exited in remote.c. These functions set those
> target_has_* to 0 and 1 appropriately. They are currently only
> used on remote-sim.c. Let me know if there is a better way to
> know if the target is running.
I think it is more likely that we shouldn't be doing whatever we're
doing until after we've finished cleaning up the target's state.
It's stuck between wait and mourn.
> tui_registers_changed_hook then has the problem that is is calling
> get_selected_frame, when target_has_registers is false. Fixed by
> using deprecated_safe_get_selected_frame here too.
This bit makes sense; you can commit it separately if you want.
--
Daniel Jacobowitz
CodeSourcery