This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Signed vs. unsigned adresses in solib-svr4


On Tue, Mar 27, 2007 at 09:16:28PM +0200, Andreas Schwab wrote:
> All but two places in solib-svr4.c assume unsigned target addresses.  This
> patch fixes these two occurences of extract_signed_integer to make things
> consistent.
> 
> Andreas.
> 
> 2007-03-27  Andreas Schwab  <schwab@suse.de>
> 
> 	* solib-svr4.c (LM_ADDR_FROM_LINK_MAP): Use
> 	extract_unsigned_integer instead of extract_signed_integer.
> 	(LM_DYNAMIC_FROM_LINK_MAP): Likewise.

I'd rather not unless this fixes a real problem - since I know that
the assumption is wrong for MIPS.  Isn't there an extract_address or
something like that which would be suitable?

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]