This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Cygwin] Fix for: detaching crashes the inferior.


On Apr 10 01:15, Christopher Faylor wrote:
> On Mon, Apr 09, 2007 at 03:06:20AM +0100, Pedro Alves wrote:
> >The real reason for the crashes is that we should be setting
> >the context back to the inferior, as gdb's copy contains
> >an adjusted PC.  With win32_continue we would resume the
> >inferior at the wrong address.  win32_resume takes care of
> >that, so the simple fix is to use it when detaching.
> >[...]
> Are you sure you aren't seeing problems when you attach/detach more than
> once?  I know that there is someplace that isn't getting cleared in that
> scenario.  I have thought that I fixed that problem a few times but it
> still seems to be there in the latest cygwin release.

What "someplace" are you referring to, Chris?  Maybe that can be solved,
too, while we're at it.

> Anyway, I'd like Corinna to comment on this if possible since that
> particular piece of code that you're patching is hers, I believe.

Calling win32_resume seems actually to be the better choice here.  The
patch looks ok to me.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]