This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[rfc][0/13] Eliminate read_register et al


Hello,

the following patch set eliminates the routines read_register, 
read_register_pid, write_register, and write_register_pid, including
all their callers.  This is the next step towards removing the
current_regcache global variable.

The patch set consists of 13 parts:

First some special read_register et al uses:
[1/13] write_register in solib-sunos.c
[2/13] read_register in cris/frv_stopped_data_address
[3/13] read_register in mep-tdep.c current_ routines
[4/13] read_register in deprecated_mips_set_processor_regs_hack
[5/13] read_register in sh_show_regs_command
[6/13] read_register (invalidly) used in prologue analyzers

Then more general classes of uses:
[7/13] Uses that are already unnecessary
[8/13] Uses in software_single_step callbacks
[9/13] Uses in skip_trampoline callbacks
[10/13] Uses in get_longjmp_target callbacks
[11/13] Uses in push_dummy_code callbacks
[12/13] Uses in read_pc / write_pc callbacks

And finally:
[13/13] Remove definition

I'd appreciate any comments; in particular some the areas touched by
the first set of patches could probably need a more general cleanup
anyway ...


I've tested the full patch set natively on:
powerpc64-linux
powerpc-ibm-aix5.3.0.0
spu-elf
s390-ibm-linux
s390x-ibm-linux
i386-linux
ia64-linux

and on the simulator for:
arm-elf
mips-elf
sh-elf
v850-elf

Architectures touched but untested as I have neither native
hardware nor a working (toolchain or) simulator:
alpha
amd64
avr
cris
frv
m32c
m32r
m68hc11
m68k
m88k
mep
mn10300
sparc
xstormy16

Additional testers would certainly be welcome!


In addition, tested by running gdb-mbuild.sh and making sure every
file touched by the patch set still builds.


Any opinions?  Should I proceed with this patch set?

Thanks,
Ulrich


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]