This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Remove macros {SP,PC,PS,FP0}_REGNUM from gdbarch.sh
- From: Markus Deuling <deuling at de dot ibm dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org, uweigand at de dot ibm dot com
- Date: Wed, 13 Jun 2007 19:48:17 +0200
- Subject: Re: [rfc] Remove macros {SP,PC,PS,FP0}_REGNUM from gdbarch.sh
- References: <466FEE63.7010302@de.ibm.com> <ups3ziwuu.fsf@gnu.org>
Eli Zaretskii wrote:
Date: Wed, 13 Jun 2007 15:17:23 +0200
From: Markus Deuling <deuling@de.ibm.com>
CC: Ulrich Weigand <uweigand@de.ibm.com>
this patch removes following macros from gdbarch.sh:
* SP_REGNUM
* PC_REGNUM
* PS_REGNUM
* FP0_REGNUM
You do this in go32-nat.c, which I think will break the DJGPP port,
because AFAIK it doesn't support gdbarch.
Hm, the only of these 4 macros used in g032-nat.c is FP0_REGNUM. I don't see any
other definition of FP0_REGNUM beside the one in gdbarch.h
#if !defined (GDB_TM_FILE) && defined (FP0_REGNUM)
#error "Non multi-arch definition of FP0_REGNUM"
#endif
#if !defined (FP0_REGNUM)
#define FP0_REGNUM (gdbarch_fp0_regnum (current_gdbarch))
#endif
So go32-nat.c uses gdbarch_fp0_regnum, doesn't it? What am I overseeing?
Thank you very much for your review.
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com