This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Remove macro DEPRECATED_FUNCTION_START_OFFSET
- From: Daniel Jacobowitz <drow at false dot org>
- To: Markus Deuling <deuling at de dot ibm dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Ulrich Weigand <uweigand at de dot ibm dot com>
- Date: Wed, 13 Jun 2007 15:11:13 -0400
- Subject: Re: [rfc] Remove macro DEPRECATED_FUNCTION_START_OFFSET
- References: <46703FA7.1030707@de.ibm.com>
On Wed, Jun 13, 2007 at 09:04:07PM +0200, Markus Deuling wrote:
> Hello,
>
> this patch completely removes macro DEPRECATED_FUNCTION_START_OFFSET. This
> macro is deprecated
> and was replaced by gdbarch_convert_from_func_ptr_addr. Build and test on x86.
> Testsuite showed no regression.
>
> ChangeLog:
> * gdbarch.sh (DEPRECATED_FUNCTION_START_OFFSET): Remove.
> * cli/cli-cmds.ci (disassemble_command): Replace
> DEPRECATED_FUNCTION_START_OFFSET by gdbarch_convert_from_func_ptr_addr.
> * symtab.c (skip_prologue_using_sal,find_function_start_sal): Likewise.
> * linespec.c (minsym_found): Likewise.
> (target.h): New include.
> * infrun.c (handle_inferior_event): Likewise.
> * infcall.c (find_function_addr): Likewise.
> * Makefile.in (linespec.o): Update dependency to target.h.
> * gdbarch.c, gdbarch.h: Regenerate.
>
> Is this ok to commit?
I think this should be tested on at least one target that defines
gdbarch_convert_from_func_ptr_addr. Are the new calls necessary on
those targets?
--
Daniel Jacobowitz
CodeSourcery