This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] memory leak, mi-cmd-var

From: msnyder at sonic dot net
To: "Nick Roberts" <nickrob at snap dot net dot nz>
Cc: msnyder at sonic dot net, gdb-patches at sourceware dot org
Date: Thu, 28 Jun 2007 21:31:59 -0700 (PDT)
Subject: Re: [patch] memory leak, mi-cmd-var
References: <24204.12.7.175.2.1183085800.squirrel@webmail.sonic.net> <18052.32294.978000.582803@kahikatea.snap.net.nz>

 > 'nother one from Coverity.
 >
 > 2007-06-28  Michael Snyder  <msnyder@access-company.com>
 >
 >      * mi/mi-cmd-var.c (mi_cmd_var_set_format): Free strduped memory
 >      (Coverity).  Also take the opportunity to call error earlier
 >      (before strdup).

> I don't see why the string has to be duplicated in the first place or how
> argv[1] could be NULL.  Why not just:

Well... you're right!  At least about the strdup.

About the NULL check -- it was already there, so I don't favor removing
it unles we can demonstrate that it can't be NULL.  But I'll re-submit
after eliminating the strdup.

References:
- [patch] memory leak, mi-cmd-var
  - From: msnyder
- Re: [patch] memory leak, mi-cmd-var
  - From: Nick Roberts

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]