This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Remove dead code in gdbtk/generic/gdbtk-stack.c
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: drow at false dot org (Daniel Jacobowitz)
- Cc: deuling at de dot ibm dot com (Markus Deuling), gdb-patches at sourceware dot org (GDB Patches)
- Date: Mon, 2 Jul 2007 20:37:43 +0200 (CEST)
- Subject: Re: [rfc] Remove dead code in gdbtk/generic/gdbtk-stack.c
Daniel Jacobowitz wrote:
> On Fri, Jun 22, 2007 at 09:52:24AM +0200, Markus Deuling wrote:
> > Hi,
> >
> > in gdbtk/generic/gdbtk-stack.c is an occurence of macro PC_LOAD_SEGMENT which
> > was deleted a long time
> > ago. I guess the code inside the if #define/#endif is dead code. This patch
> > removes it. I'm not sure how to test it :-)
> >
> >
> > ChangeLog:
> >
> > * gdbtk/generic/gdbtk-stack.c (get_frame_name): Remove dead code
> > (PC_LOAD_SEGMENT).
> >
> > Is this ok to commit?
>
> Two things:
>
> - PC_LOAD_SEGMENT is in gdbint, too. Could you remove it when you
> have a chance?
>
> - This patch is for Insight, so you should probably send it to the
> Insight mailing list instead.
The patch was approved by Keith Seitz off-list, so I've checked it in.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com