This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gdb.base/dump.exp: Force the correct endianness


On Wed, 25 Jul 2007, Jim Blandy wrote:

> > 2007-07-24  Maciej W. Rozycki  <macro@mips.com>
> >
> >	* gdb.base/dump.exp: Force the correct endianness for binary
> >	formats not carrying this information.
> >
> >  OK to apply?
>
> This looks reasonable --- please apply it, if you've also tested it on
> some desktop-like system.

 Well, the mips-unknown-linux-gnu host works fine natively.  I hope it
qualifies as a desktop-like system (the machine itself comes in a desktop
case if that helps).

 The "show/set endian" commands are supported universally even if the
currently chosen architecture comes in a single endianness only.  But in
that case gdb should still accept a command to force the endianness to one
already set automatically -- if that failed, it would qualify as a bug
IMO, so perhaps the change adds a useful test case as a side effect.

> Also, you should go ahead and add yourself at the proper point in the
> "Write After Approval" section of gdb/MAINTAINERS, as a separate
> commit, with a ChangeLog entry.

 Yeah, probably -- it has been too long already since I have got my
assignment sorted out.  Would it be OK to provide my both e-mail addresses
(which generally differentiate between sponsored and volunteer work) or
should I just pick one?

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]