This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] symfile.c, find_separate_debug_file




> On Thu, Aug 02, 2007 at 06:14:44PM -0700, Michael Snyder wrote:
> > Just for a change, here's one that was not inspired by Coverity.
> >
> > Find separate debug file does not work in the case where the path
> > lies in the global debug file directory -- because we stick an extra
> > slash into the pathname.
>
> Why doesn't it work with an extra slash?  It shouldn't make a
> difference.  Anyway:
>
> > * symfile.c (find_separate_debug_file): While consing up a path,
> > don't stick in an extra DIR_SEPARATOR.
>
> That's right, use DIR_SEPARATOR :-)  IS_DIR_SEPARATOR in this case, I
> think?

The existing code doesn't use it.  If you want me to undertake to
revise the code to use DIR_SEPARATOR, I'll be glad to do it.

But it shouldn't hold up this patch.




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]