This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] [01/12] Get rid of current_gdbarch in aix-thread.c


> Date: Fri, 03 Aug 2007 14:09:59 +0200
> From: Markus Deuling <deuling@de.ibm.com>
> 
> this patch gets rid of some of the current_gdbarch's in aix-thread.c

Thanks!

> Is this ok to commit?

I have a minor nit with the way you describe the changes in the
ChangeLog:

> 	* aix-thread.c (supply_gprs64, supply_fprs, supply_sprs64)
> 	(supply_sprs32, fetch_regs_user_thread, fetch_regs_kernel_thread)
> 	(fill_gprs64, fill_gprs32, fill_fprs, fill_sprs64, fill_sprs32)
> 	(store_regs_user_thread, store_regs_kernel_thread): Use FRAME or
> 	REGCACHE to recognize current architecture.

What are FRAME and REGCACHE here?  They are not variables nor macros
seen in the patches.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]