Re: [rfc] [01/12] Get rid of current_gdbarch in aix-thread.c

[Markus Deuling <deuling at de dot ibm dot com>]

Hi Eli,

Eli Zaretskii schrieb:
> > Date: Fri, 03 Aug 2007 14:09:59 +0200
> > From: Markus Deuling <deuling@de.ibm.com>
> >
> > this patch gets rid of some of the current_gdbarch's in aix-thread.c
>
> Thanks!
>
> > Is this ok to commit?
>
> I have a minor nit with the way you describe the changes in the
> ChangeLog:
>
> > 	* aix-thread.c (supply_gprs64, supply_fprs, supply_sprs64)
> > 	(supply_sprs32, fetch_regs_user_thread, fetch_regs_kernel_thread)
> > 	(fill_gprs64, fill_gprs32, fill_fprs, fill_sprs64, fill_sprs32)
> > 	(store_regs_user_thread, store_regs_kernel_thread): Use FRAME or
> > 	REGCACHE to recognize current architecture.
>
> What are FRAME and REGCACHE here?  They are not variables nor macros
> seen in the patches.

sorry for being unprecise. What I meant is for example REGCACHE parameter here:

static void
supply_gprs64 (struct regcache *regcache, uint64_t *vals)
{
 struct gdbarch_tdep *tdep = gdbarch_tdep (current_gdbarch);
 int regno;

So current_gdbarch can be replaced by get_regcache_arch (regcache).

Thanks for looking at that.

--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com