This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] Wrap addresses in spu-gdb


Daniel Jacobowitz wrote:
> On Wed, Aug 08, 2007 at 08:44:29AM +0200, Markus Deuling wrote:
> > +  if (target_has_registers && target_has_stack && target_has_memory
> > +      /* FIXME: Currently needed for dwarf2_read_address to work.  */
> > +      && type != builtin_type_uint32)
> 
> I think that you shouldn't commit a patch with this hack in it.
> It looks very fragile.

Agreed.  Markus, this is a special hack for the combined PPE/SPE
debugger, it shouldn't be necessary for the SPU-standalone (and
mainline) version.

I'll have to look into fixing the underlying issue cleanly when
merging the combined debugger ...

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]