This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] dwarf2read.c, memory leak

From: msnyder at sonic dot net
To: "Jim Blandy" <jimb at codesourcery dot com>
Cc: gdb-patches at sourceware dot org
Date: Wed, 8 Aug 2007 11:01:50 -0700 (PDT)
Subject: Re: [PATCH] dwarf2read.c, memory leak
References: <20951.12.7.175.2.1186279295.squirrel@webmail.sonic.net> <m3odhk5ni4.fsf@codesourcery.com>

>
> msnyder@sonic.net writes:
>> 2007-08-04  Michael Snyder  <msnyder@access-company.com>
>>
>> 	* dwarf2read.c (add_partial_symbol): Memory leak.
>
> This looks fine.

Thanks, committing.

> As a matter of taste, is it better to duplicate the 'if
> (built_actual_name) xfree (actual_name)' three times or to use 'goto'?

I recognize the validity of the question, and invite you
to decide on your own answer.  ;-)

References:
- [PATCH] dwarf2read.c, memory leak
  - From: msnyder
- Re: [PATCH] dwarf2read.c, memory leak
  - From: Jim Blandy

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]