This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] jv-lang.c, dead code
>
> msnyder@sonic.net writes:
>> noside is tested twice.
>
> I'd agree that the code is messed up, and that your patch doesn't
> change its behavior, but which test is the one that ought to be there?
> I don't even know when EVAL_SKIP would be used for Java.
In that, I would have to defer to you.
Annotate says that all four instances of EVAL_SKIP in jv-lang.c
have been there from the beginning (1999).
The only other places where it occurs are in eval.c and ada-lang.c.
I would bet that the instances in jv-lang.c were copied from
a common ancestor with the bits in eval.c. The OP_STRING case,
for instance, looks like a close cousin.