This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] dead code in mi-interp

>  > That's not what "no side effects" means - the code literally can't
>  > ever have an effect.  It creates a string which nothing uses.  Why
>  > keep it?
>
> OK, I hadn't realised that.  Unless the original author (Andrew Cagney?)
> explains why it's not needed I would still prefer that it wasn't removed.
> It
> may be that it just wasn't hooked up because the asynchronous stuff was
> never
> completed.  Once GDB can work asynchronously then it could be removed, if
> not
> needed.  Presumably "no side effects" also means "can do no harm".

Well, it can always be recovered from the CVS repository if it is
needed.  Personally I'd rathern not have dead code in there just
because it doesn't do any harm (unles it also has some benefit).
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]