This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/testsuite] backtrace in mixed language application


Hello Jerome,

> 2007-08-10  Jerome Guitton  <guitton@adacore.com>
> 
>         * gdb.ada/lang_switch/lang_switch.adb: New file.
>         * gdb.ada/lang_switch/foo.c: Ditto.
>         * gdb.ada/lang_switch.exp: New testcase.

This looks fine to me, save for one little thing: Make sure to add
the copyright headers to foo.c and lang_switch.adb as well.

That reminds me that we're trying to move to GPLv3, and your patch
actually refers to GPLv2. I think it's fine for this patch, we'll
fix it later with the rest of the files when we manage to do the
transition. But do give this a few days for people to object before
you commit.

One tiny comment: I would prefer if foo.c followed the GNU coding
standards too, so would you mind formatting it so that the function
name starts at the beginning of the line?

Thanks,
-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]