This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MI and MI2 should have identical behavior on -target-download command


What behavior do you want for mi3?

I think it's reasonable to make mi2 and mi3 work similarly on -target-download. At least, until MI3 becomes a default,
and GDB community comes up with a different ideas about it.


I understood Daniel has the same opinion (see the follow-up email).

-- Maxim

Nick Roberts wrote:
> It fixes a small glitch in GDB MI. MI2 is a default. So
> MI and MI2 should work identically. The MI2 being set as
> a default is hard-coded in several places. I think one
> place was missed:
> > mi/mi-main.c::mi_load_progress().
> > Without this fix, MI "-target-download" command behaves
> differently on MI versus MI2 not showing loading progress,
> when "-i=mi2" is used.
>
> GDB front-ends developers might want to stick with "-i=mi"
> assuming they always use a default. It would be a bad idea
> to force them to use explicit options like "-i=mi2".


What behaviour do you want for mi3?

 >...
 > -  if (current_interp_named_p (INTERP_MI))
 > +  if (current_interp_named_p (INTERP_MI)
 > +      || current_interp_named_p (INTERP_MI2))
 >      uiout = mi_out_new (2);
 >    else if (current_interp_named_p (INTERP_MI1))
 >      uiout = mi_out_new (1);



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]