This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RFA: Delete broken and unused HPUXHPPA code


The #ifdef block this patch deletes contains unbalanced parenthesis;
it wouldn't compile.  The mistake was introduced by this change:

    2005-02-10  Andrew Cagney  <cagney@gnu.org>

            Mark up all error and warning messages.

Since nobody has noticed it, it's clear that nobody has compiled this
code with HPUXHPPA defined for two and a half years.  The block of
code itself dates from GDB's prehistory.  This is the only "HPUXHPPA"
block in all of GDB.

Can we delete the code?

gdb/ChangeLog:
2007-08-29  Jim Blandy  <jimb@codesourcery.com>

	* breakpoint.c (watch_command_1): Remove '#ifdef HPUXHPPA' block;
	this code has not been compiled for two years.

Index: gdb/breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.262
diff -u -r1.262 breakpoint.c
--- gdb/breakpoint.c	23 Aug 2007 18:08:26 -0000	1.262
+++ gdb/breakpoint.c	29 Aug 2007 18:01:36 -0000
@@ -5767,28 +5767,6 @@
 	error (_("Target can only support one kind of HW watchpoint at a time."));
     }
 
-#if defined(HPUXHPPA)
-  /*  On HP-UX if you set a h/w
-     watchpoint before the "run" command, the inferior dies with a e.g.,
-     SIGILL once you start it.  I initially believed this was due to a
-     bad interaction between page protection traps and the initial
-     startup sequence by the dynamic linker.
-
-     However, I tried avoiding that by having HP-UX's implementation of
-     TARGET_CAN_USE_HW_WATCHPOINT return FALSE if there was no inferior_ptid
-     yet, which forced slow watches before a "run" or "attach", and it
-     still fails somewhere in the startup code.
-
-     Until I figure out what's happening, I'm disallowing watches altogether
-     before the "run" or "attach" command.  We'll tell the user they must
-     set watches after getting the program started. */
-  if (!target_has_execution)
-    {
-      warning (_("can't do that without a running program; try \"break main\"), \"run\" first");
-      return;
-    }
-#endif /* HPUXHPPA */
-
   /* Change the type of breakpoint to an ordinary watchpoint if a hardware
      watchpoint could not be set.  */
   if (!mem_cnt || target_resources_ok <= 0)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]