This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] gnu-v2-abi.c: strchr may return null
- From: msnyder at sonic dot net
- To: "Joel Brobecker" <brobecker at adacore dot com>
- Cc: msnyder at sonic dot net, gdb-patches at sourceware dot org
- Date: Tue, 4 Sep 2007 17:03:56 -0700 (PDT)
- Subject: Re: [patch] gnu-v2-abi.c: strchr may return null
- References: <16934.12.7.175.2.1188422744.squirrel@webmail.sonic.net> <20070904141830.GC3579@adacore.com>
>> 2007-08-29 Michael Snyder <msnyder@access-company.com>
>>
>> * gnu-v2-abi.c (gnuv2_value_rtti_type): Guard against null.
>
> This looks OK to me, but can you give it a few more days so that Daniel
> can provide any comment on it (C++ is not our main focus at AdaCore)?
On Daniel's subsequent approval (or acquiescence?), committing.
> I'm thinking this is perhaps a case where an assert might be better:
> Does the rest of the function make any sense if we don't find our
> space? I don't know the encoding so perhaps it's OK to give it a try...
Well, it won't make it any worse. If any reason manifests itself
to go with an assert, we can do that.