This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] gnu-v2-abi.c: strchr may return null


>> 2007-08-29  Michael Snyder  <msnyder@access-company.com>
>>
>> 	* gnu-v2-abi.c (gnuv2_value_rtti_type): Guard against null.
>
> This looks OK to me, but can you give it a few more days so that Daniel
> can provide any comment on it (C++ is not our main focus at AdaCore)?

On Daniel's subsequent approval (or acquiescence?), committing.

> I'm thinking this is perhaps a case where an assert might be better:
> Does the rest of the function make any sense if we don't find our
> space? I don't know the encoding so perhaps it's OK to give it a try...

Well, it won't make it any worse.  If any reason manifests itself
to go with an assert, we can do that.




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]