This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-fork.c
The include ordering stuff seems completely
opaque to me anyhow.
<ctype.h> is included as last in linux-fork.c,
but right after "defs.h" in breakpoint.c.
Is there any rational for this?
Anyhow, if you also agree, it is probably best to leave
the ordering exactly as it was, just to stay on the
safe side.
Should I move the gdb_wait.h include back to where wait.h was?
Pierre
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Joel Brobecker
> Sent: Monday, October 08, 2007 3:59 PM
> To: Pierre Muller
> Cc: 'Mark Kettenis'; gdb-patches@sourceware.org
> Subject: Re: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-
> fork.c
>
> > Maybe, but in my latest commit to linux-fork.c I did exactly
> > the same operation for the wait header, and moved it up from
> > the system <header.h> includes to the local "header.h" includes,
> > and Joel told me that this was the right thing to do...
>
> Maybe I was wrong :-o. Seriously, the reason why I said yes at the time
> is because I didn't think it would make a difference. I don't think
> it will make a difference here either, but Mark's approach is less
> prone to cause unexpected behavior changes.
>
> --
> Joel