This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA] small cleanup in buildsym.c


Hello,

While doing some code cleanup in our sources, I noticed that
buildsym had some #if 0 and some #if 1. This patch addresses
the ones that look the most obvious to me, the #if 0. I don't
know why this code was #ifdef'ed out instead of simply deleted.
cvs annotate shows that it predates the public CVS. Since it's
been 8 years, I think we can safely remove them. I noticed one
area where we could actually factorize the code, even if actual
function body is the same as the one line we're replacing, the
function has a comment inside that explains why we're doing
so little.

2007-10-23  Joel Brobecker  <brobecker@adacore.com>

        * buildsym.c (free_pending_blocks): Remove commented-out code.
        (make_blockvector): Likewise. Re-use free_pending_blocks.
        (end_symtab): Remove commented-out code.

Seems pretty straightforward, but I will run it through the testsuite
before committing.

-- 
Joel

Attachment: buildsym.c.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]