This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Problems while debugging fortran
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Carlos Eduardo Seo <cseo at linux dot vnet dot ibm dot com>
- Cc: Jim Blandy <jimb at codesourcery dot com>, gdb at sourceware dot org, GDB Patches Mailing List <gdb-patches at sourceware dot org>, drow at false dot org
- Date: Thu, 25 Oct 2007 13:41:34 -0700
- Subject: Re: Problems while debugging fortran
- References: <19c433eb0710250906k392cecf8t1f99595d5c5a8107@mail.gmail.com> <20071025170621.GA27275@caradoc.them.org> <m3lk9rxceq.fsf@codesourcery.com> <20071025190150.GA1560@caradoc.them.org> <m3tzof9eqq.fsf@codesourcery.com> <20071025202406.GC4063@adacore.com> <4720FE48.8020200@linux.vnet.ibm.com>
> 2007-10-25 Wu Zhou <woodzltc@cn.ibm.com>
> Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
> Jim Blandy <jimb@codesourcery.com>
>
> * dwarf2read.c (read_partial_die): check the value
> of DW_AT_calling_convention in Fortran programs.
Just one minor comment:
> + if ((DW_UNSND (&attr) == DW_CC_program) && (cu->language == language_fortran))
Could you remove the unnecessary extra parens and split this line
into two (it's too long):
if (DW_UNSND (&attr) == DW_CC_program
&& cu->language == language_fortran)
Your patch is approved with that adjustment.
Thanks,
--
Joel