This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
PATCH: tracepoints: Remove unused functions
- From: Jim Blandy <jimb at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 26 Oct 2007 16:42:16 -0700
- Subject: PATCH: tracepoints: Remove unused functions
Committed as obvious.
gdb/ChangeLog:
2007-10-26 Jim Blandy <jimb@codesourcery.com>
* ax-gdb.c (expr_to_agent): Delete unused function.
(expr_to_address_and_size): Delete #if 0'd function.
* ax-gdb.h (expr_to_agent): Delete declaration.
diff -r 3e791181e789 -r db46634d8623 gdb/ax-gdb.c
--- a/gdb/ax-gdb.c Thu Oct 25 14:08:00 2007 -0700
+++ b/gdb/ax-gdb.c Fri Oct 26 16:39:42 2007 -0700
@@ -1745,56 +1745,6 @@ gen_expr (union exp_element **pc, struct
/* Generating bytecode from GDB expressions: driver */
-/* Given a GDB expression EXPR, produce a string of agent bytecode
- which computes its value. Return the agent expression, and set
- *VALUE to describe its type, and whether it's an lvalue or rvalue. */
-struct agent_expr *
-expr_to_agent (struct expression *expr, struct axs_value *value)
-{
- struct cleanup *old_chain = 0;
- struct agent_expr *ax = new_agent_expr (0);
- union exp_element *pc;
-
- old_chain = make_cleanup_free_agent_expr (ax);
-
- pc = expr->elts;
- trace_kludge = 0;
- gen_expr (&pc, ax, value);
-
- /* We have successfully built the agent expr, so cancel the cleanup
- request. If we add more cleanups that we always want done, this
- will have to get more complicated. */
- discard_cleanups (old_chain);
- return ax;
-}
-
-
-#if 0 /* not used */
-/* Given a GDB expression EXPR denoting an lvalue in memory, produce a
- string of agent bytecode which will leave its address and size on
- the top of stack. Return the agent expression.
-
- Not sure this function is useful at all. */
-struct agent_expr *
-expr_to_address_and_size (struct expression *expr)
-{
- struct axs_value value;
- struct agent_expr *ax = expr_to_agent (expr, &value);
-
- /* Complain if the result is not a memory lvalue. */
- if (value.kind != axs_lvalue_memory)
- {
- free_agent_expr (ax);
- error (_("Expression does not denote an object in memory."));
- }
-
- /* Push the object's size on the stack. */
- ax_const_l (ax, TYPE_LENGTH (value.type));
-
- return ax;
-}
-#endif
-
/* Given a GDB expression EXPR, return bytecode to trace its value.
The result will use the `trace' and `trace_quick' bytecodes to
record the value of all memory touched by the expression. The
diff -r 3e791181e789 -r db46634d8623 gdb/ax-gdb.h
--- a/gdb/ax-gdb.h Thu Oct 25 14:08:00 2007 -0700
+++ b/gdb/ax-gdb.h Fri Oct 26 16:39:42 2007 -0700
@@ -91,11 +91,6 @@ struct axs_value
/* Translating GDB expressions into agent expressions. */
-/* Given a GDB expression EXPR, translate it into the agent bytecode,
- and return it. FLAGS are from enum expr_to_agent_flags. */
-extern struct agent_expr *expr_to_agent (struct expression *EXPR,
- struct axs_value *VALUE);
-
/* Given a GDB expression EXPR denoting an lvalue in memory, produce a
string of agent bytecode which will leave its address and size on
the top of stack. Return the agent expression. */