This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: tracepoints: Report tracepoint deletions properly
- From: Michael Snyder <msnyder at specifix dot com>
- To: Jim Blandy <jimb at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 27 Oct 2007 01:14:23 -0700
- Subject: Re: PATCH: tracepoints: Report tracepoint deletions properly
- References: <m3d4v1flf3.fsf@codesourcery.com>
On Fri, 2007-10-26 at 17:31 -0700, Jim Blandy wrote:
> Committed as obvious.
>
> I don't think this matters a bit, as there seem to be no clients of
> this particular event, unless I've missed something.
I suspect it was meant for a gui framework that was never written.
Hopefully as a result of your work, people will actually start to
use tracepoints, and eventually we will want a gui framework for
them. But I see no reason not to remove them for now, and add
what we really need when we really need it.
> gdb/ChangeLog:
> 2007-10-26 Jim Blandy <jimb@codesourcery.com>
>
> * tracepoint.c (tracepoint_operation): Report the deletion event
> after we have unlinked the tracepoint from the list, and use the
> proper tracepoint number.
>
> diff -r db46634d8623 gdb/tracepoint.c
> --- a/gdb/tracepoint.c Fri Oct 26 16:39:42 2007 -0700
> +++ b/gdb/tracepoint.c Fri Oct 26 17:25:51 2007 -0700
> @@ -583,10 +583,11 @@ tracepoint_operation (struct tracepoint
> ALL_TRACEPOINTS (t2)
> if (t2->next == t)
> {
> - tracepoint_delete_event (t2->number);
> t2->next = t->next;
> break;
> }
> +
> + tracepoint_delete_event (t->number);
>
> if (t->addr_string)
> xfree (t->addr_string);