This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] printf support for DFP values
- From: Eli Zaretskii <eliz at gnu dot org>
- To: luisgpm at linux dot vnet dot ibm dot com
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 01 Nov 2007 06:10:44 +0200
- Subject: Re: [PATCH] printf support for DFP values
- References: <1193449497.6950.22.camel@localhost> <ubqaksyin.fsf@gnu.org> <1193669215.4800.10.camel@localhost> <ur6jdr8iy.fsf@gnu.org> <20071029201252.GA21583@caradoc.them.org> <upryxqmb5.fsf@gnu.org> <ulk9lqlmm.fsf@gnu.org> <1193753649.4283.5.camel@localhost> <uir4oqs3w.fsf@gnu.org> <1193879919.4994.2.camel@localhost>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Luis Machado <luisgpm@linux.vnet.ibm.com>
> Cc: gdb-patches@sourceware.org
> Date: Wed, 31 Oct 2007 22:18:39 -0300
>
> How does this manual entry look? I tried to make it clear, but if i
> missed something please let me know.
It's okay, modulo the following problems:
> +Printf also supports conversion specifications for DFP (Decimal Floating Point)
> +types using the following conversion letters:
"Printf" is a name of a command, so please use @code{Printf}.
Also, when you first introduce a term, such as DFP, it is good to put
it in @dfn{}, as in @dfn{Decimal Floating Point}, so that it stands
out.
> +Printing DFP types with the conversion letters seen before works as
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +the example:
"with the above conversion letters" is better.
Also, I'd rephrase this:
Here's an example of printing DFP types using the above conversion
letters:
Other than that, the patch for the manual is fine. Thanks.