This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] [04/09] Get rid of current_gdbarch (SIZEOF_FRAME_SAVED_REGS macro)

On Mon, Nov 05, 2007 at 02:43:29PM +0100, Mark Kettenis wrote:
> > Date: Mon, 05 Nov 2007 13:21:29 +0100
> > From: Markus Deuling <deuling@de.ibm.com>
> > 
> > Hi,
> > 
> > this patch replaces SIZEOF_FRAME_SAVED_REGS macro by its expression.
> > 
> > Tested by gdb_mbuild with alpha target. Is this ok to commit?
> 
> I'm not thrilled, since this replaces a #define that has a sensible
> name with some sort of complicated expression, and therefore makes the
> code much more difficult to read.

Ditto.  frame_zalloc_saved_regs (frame)?

-- 
Daniel Jacobowitz
CodeSourcery
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]