This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Remove 'run cleanup chain'
- From: Jim Blandy <jimb at codesourcery dot com>
- To: Vladimir Prus <vladimir at codesourcery dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 14 Nov 2007 14:44:05 -0800
- Subject: Re: Remove 'run cleanup chain'
- References: <200711141553.54912.vladimir@codesourcery.com>
Vladimir Prus <vladimir at codesourcery.com> writes:
> GDB now has a special 'run cleanup chain', but it seems to
> be not really needed.
>
> This cleanup chain is only used to call clear_solib in response
> to 'run' command. However:
> - Just calling clear_solib is much simpler
> - We need to call clear_solib for attach, too, and it's done
> via direct call, so it's better to have run be similar to
> attach.
>
> There's comment in jv-lang.c that hints that the run cleanup can
> be useful, but is broken, and the code containing the
> comment is not actually used itself.
>
> So, it seems to me that carrying this general code for the
> sake of a single client that is only complicated as result is not good,
> here's a patch to remove run cleanup chain. OK?
This needs a ChangeLog entry. :)