Re: delete_breakpoint: don't try to insert other breakpoints

[Vladimir Prus <ghost at cs dot msu dot su>]

Daniel Jacobowitz wrote:

> On Fri, Nov 16, 2007 at 01:13:51PM +0200, Eli Zaretskii wrote:
>> > > I'm okay with making the code cleaner, but on at a price of removing
>> > > features, even if they are currently unused.
> 
>> I'm sorry, I already said why I'm opposed to it.  I have nothing
>> further to add to what I said.
> 
> I have to say I don't understand this conversation either.  Eli, how
> is code which will never be reached a feature?  Vlad, you said this
> would be cleaner if it just went back to insert_breakpoints; can we
> do that?  Or insert_bp_location, I think.

I just was about to suggest that, but... if I convert this to
insert_breakpoints/insert_bp_location, I cannot actually test it
using current gdb.

In order to test it, I'd need to change GDB to stop deleting
breakpoints from inferior whenever it stops -- and such a change
will likely require rewriting major bits of functionality. I think
it's better to remove code that is apparently not used, and
then revive parts of it as needed for future features (which would
be tested), then hope this code will work.

- Volodya