This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] MI: lvalues and variable_editable
Nick Roberts <nickrob <at> snap.net.nz> writes:
> > I believe this test captures CPLUS_FAKE_CHILD as well, so you don't
> > need to have separate test for that.
>
> I'll remove it.
...
> > > Â Â /* FIXME: define masks for attributes */
> > > ! Â if (!varobj_editable_p (var))
> > > Â Â Â error (_("mi_cmd_var_assign: Variable object is not editable"));
> >
> > I presume the FIXME is now stale?
>
> I'll remove that too
...
> > Aside from the minor points above, I don't have any objections to this
> > patch. Dan, what would you say?
Just to clarify -- who's got the ball now? Nick, are you planning to post a
revised patch, or are you waiting for Dan to approve the reminder of the patch?
- Volodya