This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Ignore breakpoints when reading memory.


> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 1 Dec 2007 14:19:45 +0300
> 
> This commit prepares us for always-inserted-breakpoints mode.
> If breakpoints are always inserted, then reading the code memory
> will read the breakpoint instructions, not the original content.
> This patch makes us try to restore the original comments using
> the breakpoints table. OK?

So now reading from target memory will need to traverse the complete
list of inserted breakpoints.  Did you do any benchmarking to see what
the impact of this change is, especially when running on a somewhat
slow machine?

> 	* breakpoint.h (breakpoint_restore_shadows): New
> 	declaration.
> 	* breakpoint.c (breakpoint_restore_shadows): New.
> 	(read_memory_nobpt): Use breakpoint_restore_shadows.
> 	* target.c (memory_xfer_partial): Call
> 	breakpoint_restore_shadows.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]