Re: [rfc] Multiple process support in gdbserver

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Fri, 7 Dec 2007 16:23:52 -0500
> From: Daniel Jacobowitz <drow@false.org>
> 
> +@subsubsection Multi-Process Mode for @code{gdbserver}

This subsubsection could benefit from a @cindex entry, since it
describes an important functionality.

> -was compiled with the correct sysroot using @code{--with-system-root}).
> +was compiled with the correct sysroot using @code{--with-sysroot}).

Does this mean the previous wording was just plain wrong, or are you
changing the option's spelling?

> +@item monitor exit
> +Tell gdbserver to exit immediately.  This command should be followed by
> +@code{disconnect} to close the debugging session.  @code{gdbserver} will
> +detach from any attached processes and kill any processes it created.

A short explanation how this is used in multi-process debugging would
be good here.

> +This packet is only available in extended mode.

Suggest a cross-reference to where extended mode is explained.

> @@ -24775,7 +24877,7 @@ return -1 if an error occurs.  @var{path
>  @var{flags} is an integer indicating a mask of open flags
>  (@pxref{Open Flags}), and @var{mode} is an integer indicating a mask
>  of mode bits to use if the file is created (@pxref{mode_t Values}).
> -@xref{open} for details of the open flags and mode values.
> +@ref{open} for details of the open flags and mode values.

@ref does not produce a "see", so the above is wrong.  Why did you
replace @xref in the first place, it looks allright here (except that
you need a comma after the right brace)?

> +* The GDB remote stub, gdbserver, now supports run and attach in
> +extended-remote mode.

Is "extended-remote mode" a known term?  If not, we should probably
explain it, or else replace it with a more plain-language description
of it.

Other that these comments, the documentation patches are approved.

Thanks.