This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch] Fix sepdebug.exp build-id occasional FAILs
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Mon, 10 Dec 2007 01:20:51 +0100
- Subject: [patch] Fix sepdebug.exp build-id occasional FAILs
Hi,
a bug in my own code - a forgotten binary type, I should learn better Tcl.
It FAILs only for specific deterministically-random build-id hashes, this one
4edd6ca0c5be6b98d27ae5f0b31bbfe782ebd2aa
was read incorrectly as
4edd6ca07e6b98d27ae5f0b31bbfe782ebaa
resulting in
FAIL: build-id: breakpoint function, optimized file
FAIL: build-id: breakpoint small function, optimized file
FAIL: build-id: run until function breakpoint, optimized file
FAIL: build-id: run until function breakpoint, optimized file
FAIL: build-id: run until breakpoint set at small function, optimized file
Approval requested although the fix is obvious.
Sorry,
Jan
2007-12-09 Jan Kratochvil <jan.kratochvil@redhat.com>
* lib/gdb.exp (build_id_debug_filename_get): OBJCOPY pipe being read
must be set to binary.
--- ./gdb/testsuite/lib/gdb.exp 9 Dec 2007 11:21:21 -0000 1.93
+++ ./gdb/testsuite/lib/gdb.exp 10 Dec 2007 00:14:55 -0000
@@ -2500,6 +2500,7 @@ proc build_id_debug_filename_get { exec
return ""
}
set fi [open $tmp]
+ fconfigure $fi -translation binary
# Skip the NOTE header.
read $fi 16
set data [read $fi]