This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [commit] remove opaque enum declaration in symtab.h

From: Joel Brobecker <brobecker at adacore dot com>
To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
Cc: gdb-patches at sourceware dot org
Date: Thu, 20 Dec 2007 09:40:15 +0400
Subject: Re: [commit] remove opaque enum declaration in symtab.h
References: <20071219132546.GC6154@adacore.com> <20071219140458.GB20359@caradoc.them.org> <20071219140831.GD6154@adacore.com> <200712191422.lBJEMU3J004356@brahms.sibelius.xs4all.nl>

> > > > 2007-12-19  Joel Brobecker  <brobecker@adacore.com>
> > > > 
> > > >         * symtab.h: #include "defs.h".
> > > 
> > > FYI, this is not necessary; defs.h is always included first and
> > > everything depends on it.
> > 
> > Should I remove it, then? We have other .h files that include defs.h,
> > perhaps we should take care of them too...
> 
> Yes please.

Fixed with the attached patch.

2007-12-20  Joel Brobecker  <brobecker@adacore.com>

        * symtab.h: Remove "defs.h" #include.
        * Makefile.in (symtab_h): Update dependencies.

Thanks for the feedback.  I will send a patch for the remaining
unexpected includes.

-- 
Joel

Attachment: defs.diff
Description: Text document

References:
- [commit] remove opaque enum declaration in symtab.h
  - From: Joel Brobecker
- Re: [commit] remove opaque enum declaration in symtab.h
  - From: Daniel Jacobowitz
- Re: [commit] remove opaque enum declaration in symtab.h
  - From: Joel Brobecker
- Re: [commit] remove opaque enum declaration in symtab.h
  - From: Mark Kettenis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]